feat(reveal.js): add support for fragment indices in line highlighting#13125
Open
mcanouil wants to merge 10 commits intoquarto-dev:mainfrom
Open
feat(reveal.js): add support for fragment indices in line highlighting#13125mcanouil wants to merge 10 commits intoquarto-dev:mainfrom
mcanouil wants to merge 10 commits intoquarto-dev:mainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
|
Thanks for initiating ! Could be also related to
Also, do we have an issue about this new feature with a discussion or only the Slack question? And regarding naming, I think I would like to handle this one too before adding new options Just listing all this as thoughts for later. |
Collaborator
Author
|
Thanks for linking. The changes would indeed fix both issues. (I'm not linking them formally at this point to avoid risking closing the issues) The PR is mostly here to not lose the code. |
Collaborator
Author
|
I updated the PR for it to be more complete: changelog, test, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce support for fragment indices to enhance line highlighting functionality, allowing for more precise control over highlighted code segments in Reveal.js.
This adds a
code-line-fragment-indicesattribute to offer control over fragment.When set, the same number of fragment indices as there are steps are required.
I'm not sure of the other changes that this new feature should be coming with.